So if you do the Docker setup, obeying the instructions and substituting everything that needs to get substituted, but don’t proofread the files in detail and so miss that line 40 of docker-compose.yml doesn’t have the variable {{domain}} like in every other location you need to write your domain, but instead just says LEMMY_UI_LEMMY_EXTERNAL_HOST=lemmy.ml and so you fail to change it away from lemmy.ml… then, everything will work, until you type in your admin password for the first time, at which point your browser will send a request to lemmy.ml which includes your admin username, your email address, and the admin password you’re trying to set. And, also, of course your IP address wherever you are sitting and setting up the server.
I have no reason at all to think the Lemmy devs have set their server up to log this information when it comes in. nginx will throw it away by default, of course, but it would be easy for them to have it save it instead, if they wanted to. And my guess is most people won’t use a different admin password once they figure out why creating their admin user isn’t working and fix it.
@dessalines@lemmy.ml @nutomic@lemmy.ml I think you should fix the docker-compose.yml file not to do this.
You should edit your post with link to this PR - it’s fixed now
Edited.
Thanks
Oh no, the secret plot of the tankies for world domination has been unmasked!
Why make a Lemmy post about this and not just a GitHub issue?
I think it should be more public knowledge than just people who peruse the github issues. Also, it’s so trivial to fix that it will save them some time if they don’t have to close the issue after they spend literally 10-15 seconds fixing it.
I think you should also make a GitHub issue too
It would literally take me longer to make the github issue than it would take them to fix it, by quite a big margin. You can make one for it, if you still feel super-strongly about it though.
I could have that PR up in like 5 minutes. And poop while I was doing it.
It literally takes a minute to make a GitHub issue and you could have linked it here for your conversation. Probably would have helped the admins of ml change things. Especially considering that things like this get overlooked all the time in open source projects.
I am a lazy unreliable person. But I find value in what you found and want it fixed.
If you don’t do it, it probably will not get fixed so fast
I cannot imagine any responsible dev who would read this notification and say anything other than “Oh shit, yeah, that’s really bad,” and fix it on the spot before they continue with whatever they had visited Lemmy to do. Like I say, it’s relevant that it takes literally seconds to grasp the issue and fix it.
I don’t fully disagree with you, I get it, github issues is where issues with the software belong. I wasn’t trying to be a jerk by suggesting that you do it. Anyone from these comments is welcome to. But, also, I am sort of curious about what their reaction will be. Finding out that kind of thing is interesting to me.
If they are actively uninterested in fixing it, however they get made aware of it, then that’s really interesting.
Oh I abso-fucking-lutely can imagine seeing someone spamming me with DMs or making a public post to try and shame me instead of commenting on the actual source project going straight into my “ignore this twat” pile. This post is just a cry for attention. You’re trying to be some sort of hero, saving us from evil or some shit.
Go make a GitHub request like a reasonable normal person and stop cluttering up others feeds with this inane bs.
I am not typing here in the hopes that they will fix it. I am typing here to communicate to other users what’s up with it. Whether or not to fix it is up to them. You’re welcome to your opinion.
Pretty sure it’s an oversight but devs are overworked, really overworked
There are many more important things to fix before this.
But an issue will put it in the todo list
I wouldn’t give them the benefit of the doubt, the devs are dodgy fuckers.
Within the last hour, dessalines has posted three things about communism that are longer than the fix for this issue.
Edit: Everyone’s got the right to do whatever they want to do. I’m not trying to accuse anyone of not spending enough time making software for me, just because occasionally they might want to do some other things with their life. The thing I’m trying to emphasize with this is how short the fix is. It’s seconds. It’s not one of those “but you have to recompile, what about this other branch” or anything like that. It’s literally a fairly critical security fix with 100% of the fix in a one-line change to a documentation file.
And look at how much time you wasted defending your position to not post a github issue. Fucking unbelievable that you will publicly complain but NOT bring the issue up with the devs
Fuck people like you
There is no other reason to do it like this in a Lemmy post other than you want to publicly discredit the devs somehow. This is quite obviously a mistake and not a way to harvest admin passwords. Just fixing it and not trying to stir up shit would have been the right thing to do.
“Why would I get the notice through the proper means where they can fix it, when I can make a public post that doesn’t actually solve the issue at hand?”
The same thing as people who think reddit threads are bug reports.
I frequently make bug reports and contributions to all kinds of software. If this wasn’t something that impacted people’s security and trust evaluation, that’s exactly what I would have done.
Put it this way: If Android, or Outlook or whatever, was sending your admin password home to Google or Microsoft, and then people showed up to say it was probably an innocent mistake and why are you even making a big deal about it, just report it and let them fix it instead of creating drama, that would be absurd. That’s how I feel about the people here telling me the same thing.
Just for the hell of it, I don’t know about OP, but I don’t even know how to.
I went to the relevant linked section and couldn’t find a way to raise an issue directly. I’m going to try again, and if I succeed I’ll return here and make a top level comment for anyone scrolling by and wondering. I’ve never tried to do this before, so I’ll see how it goes.
Edit: aha!
You have to go to the issues page and select the “new issue” button, where you’ll be directed to log in to github.
Which, for me, means I’m finished trying. No desire whatsoever to have another login for a one time thing. If I ever manage to learn enough code to do anything like this often enough, I’d do it, but it just isn’t worth it to satisfy my curiosity about the process.
OP managed to find the bug. He knows how to fix it. Obviously he’d know how to make an issue about it, and probably even know how to contribute his fix that he already made in the official way to the open source project.
You do not possess these skills so obviously you’re not the one who should make the issue.
Yet he decided to somehow create this public post highlighting something that could be sketchy to try to publicly discredit the devs. There is no other reason to do it like this.
If it could be sketchy the public should know about it.
The people that didn’t change their password after it getting leaked should also know about it and update their info.
Whistleblowers like Op are doing the right thing. No blind faith in some dear leader.
Why try to fix the issue if you can just farm some drama?
Because the main Lemmy devs are authoritarian assholes.
Thank you for discovering this, and creating awareness around it.
Seems like a genuine miss, contrary to what the comments here would have one believe, given that the compose file (and rest of the docs) were mostly derived from whatever worked for the developers themselves.
Seems like a genuine miss, contrary to what the comments here would have one believe,
You might be right. I looked at the history and the way it came in, and it’s not as wildly anomalous to the rest of the file when looked at in context. Maybe it’s just a mistake.
if it was inadvertent you’d think someone at the receiving address would have spoken up…
Well, part of the price I pay for being a consistent dickhead is that sometimes people aren’t enthused to respond to me. I get why they wouldn’t really want to respond here and get yelled at, whether or not it was malicious, and instead just fix it and go on.
In my opinion it would be a healthier way to go about things if they were willing to meet criticism head-on, but the pro-authoritarianism position they’ve staked out for themselves is so widely and bitterly unpopular that I think that ship has sailed and they’re unlikely to engage with most of the free-speaking world at this point, because it would just be a torrent of abuse and mockery and so what would even be gained by it.
they’re unlikely to engage with most of the free-speaking world at this point, because it would just be a torrent of abuse and mockery and so what would even be gained by it.
side effects of never letting a good opportunity to red bait go to waste I guess
When it comes to tankies/rightwing/etc/etc I always assume a Reverse Hanlons Razor. Never attribute to stupidity what can be adequately explained by malice.
This is fixed now.
I really wish there was a way to enforce transparency of docker env vars.
I get that it’s impossible to make it a part of docker, env vars get parsed by code and turned into variables. There is no way that docker can enforce it, cause a null/undefined check with a default value is all that would be needed to subvert checks by docker, and every language uses a different way to check env vars (eg .env files, environment init scripts, whatever).
And even then, the env var value could be passed through a ridiculous chain of assignments and checks.
And, some of those ‘get env var’ routines could be conditional. Not all projects capture all env vars during some initial routine.I’ve spent hours (maybe days) trawling through undocumented env vars trying to figure out their purpose, in order to leverage them in docker/k8s stacks.
I wish there was something.Thankfully, a bit of time spent with a FOSS project and reviewing the code does shed light on hidden env vars.
And a PR or 2 gets comments and documentation updated.
Open source is awesomeYeah, I honestly just strongly dislike the whole Docker ethos. It was designed for one thing (deployment at scale), at which it excelled, and then everyone uses it for a different thing (reproducible one-off deployment), at which it is fine, basically, but just kind of the minimum set of capabilities to get the job done.
Nix can do what Docker does, in a much superior fashion (lower disk space, much better transparency, rollback ability, lack of towering chains of follow-on effects as you are talking about, and applications outside of mucking around with containerized images), but for some reason everyone uses Docker, and Nix is as far as I can tell unused outside of NixOS.
Whatever. When they make me king, it’ll be different, that’s all I can say.
Nix and Docker / container runtimes are completely different animals. Each is good at what they do, but those are vastly different things, with some overlap. If you want to share a kernel but use fewer resources than a VM, containers can do that. If you want to go further and completely isolate, you can use microvm’s like firecracker.
I don’t follow what is wrong with that. Maybe you mean it’s use where people use it specifically as a package manager. I agree with that, but even then it has its handy place.
Maybe you mean it’s use where people use it specifically as a package manager
Precisely. Containerization is great and Docker does it well. Sending someone a reproducible script that can set up your software package for them is great. Marrying the two concepts unnecessarily and using one specific tool which is designed primarily to do the first, to instead do the second, is the only real issue I’m taking with it.
Good catch, seems like an oversight.
Yes, there are still some problems with the self-hosting docs
Do you have a link to the file you used which has this problem?
“Accidentally”
ope, just gonna squeeze on through this minefield, dont mind me
Can you point to a repository somewhere?
Thank you!
Yeah this hit me as well and it was very confusing until I found that
lemmy.mlI can’t find it on the main branch so I didn’t raise am issue
So it’s not in the repo, where did you get the compose? This smells like bullshit
The relevant repo is:
https://github.com/LemmyNet/lemmy-docs
If you wanted to submit a PR, I think that would be a good idea. I’ve posted the patch elsewhere in the comments.
rise up against dockers and the evil empire of containerization! reproducibility! microservices! middle management! security!
/j
The funny part about this post is that @dessalines@lemmy.ml literally will not post on this instance (or most instances besides the tankie triad) because he is a coward.
Ok I guess y’all are right. The funny part is the tankies annoyed by this very simple fact.
You speak truth, and the proof is that coward will not even aknowledge this news. Mark my words… tankies are just fascists of a different degeneracy.
