Full article: Firefox browser has started shipping Brave’s adblock-rust engine

After seeing a lot of backlash over Waterfox adding Brave’s adblock engine:

It looks like Waterfox is piggy-backing off of Firefox’s implementation (great!).

And it’s been there for a little while.

Mozilla bundled adblock-rust (Brave’s Rust-based adblock engine, the same one my team works on) into Firefox. Pretty exciting to see them finally start taking ad & tracker blocking seriously; I didn’t think I’d see this day. It landed in Firefox 149 via via Bugzilla Bug 2013888.

  • Matth@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    26
    ·
    7 days ago

    What’s the difference with ublock and why not contact ublock developer to propose to integrate it instead of what did Brave? Article don’t mention what is better with adblock rust! :-/

    • Bloefz@lemmy.world
      link
      fedilink
      arrow-up
      2
      ·
      4 days ago

      Ublock is way better than that brave crap. As long as they don’t start moving towards Manifest 3.0 “because we have builtin adblock now” :( I wouldn’t put it past Mozilla because they’ve really been cozying up to the ad industry. With anonym, the “privacy-preserving attribution” BS, stuff like that.

      • FriendBesto@lemmy.mlBanned
        link
        fedilink
        arrow-up
        1
        ·
        3 days ago

        Agreed, uBo is the superior solution since it is not only an ad blocker. It is so much more.

    • eleijeep@piefed.social
      link
      fedilink
      English
      arrow-up
      7
      ·
      7 days ago

      Probably for the same reason that Waterfox developers gave: Because uBO is GPL licensed and combining with an MPL licensed codebase makes things complicated for downstream developers who cannot GPL license their codebase.

      The Brave module is MPL licensed already.

      Sure, I would prefer that everything is GPL, but it’s not my project.

      • LordKitsuna@lemmy.world
        link
        fedilink
        arrow-up
        11
        arrow-down
        3
        ·
        7 days ago

        Yeah as much as I love ublock origin and use it heavily. I support more rust on more things. 60+% of browser CVE are memory issues. Rust was explicitly made to stop those.

          • LordKitsuna@lemmy.world
            link
            fedilink
            arrow-up
            3
            arrow-down
            3
            ·
            7 days ago

            No, but it’s nowhere near as strict in its management. Plenty of memory issues can still usually from unintentionally maintaining a reference to an object. forgotten global variables, uncleared timers (setInterval), or closures that stay in scope longer than necessary.

            And ofc you now have the performance overhead of GC constantly running

            • Bloefz@lemmy.world
              link
              fedilink
              arrow-up
              1
              ·
              4 days ago

              Well yeah but a lot of actual overflows need to be fixed by making the JS runtime/JIT in Rust. Not in JS itself.

              And rust doesn’t protect you from bad coding. Just like JS.